Skip to content

Conversation

@mithro
Copy link
Contributor

@mithro mithro commented Jul 9, 2025

🧪 Test PR: GitHub Action Verification

This PR tests the automated link checking GitHub Action workflow to verify it's functioning correctly.

What's Being Tested

New Test Page

  • File: test-page.md - Contains various link types for validation
  • Internal Links: Links to index.md and useful-resources.md
  • External Links: Links to github.com, python.org, and sphinx-doc.org
  • Added to toctree: Included in main documentation index

Expected GitHub Action Behavior

  1. Wait for ReadTheDocs Preview: Should detect and wait for preview deployment
  2. 🔍 Run Link Checker: Should use muffet to validate all links
  3. Pass Validation: All test links should be valid
  4. 💬 Post PR Comment: Should comment with success results
  5. Pass Status Check: Should show green check mark

Test Scenarios Covered

  • Internal navigation: Cross-references between docs pages
  • External references: Links to well-known, stable websites
  • ReadTheDocs integration: Preview URL construction and detection
  • Workflow artifacts: Full muffet output should be uploaded

Success Criteria

  • ReadTheDocs preview builds successfully
  • GitHub Action workflow completes without errors
  • Link checker finds no broken links
  • PR receives automated comment with results
  • Workflow artifacts are uploaded
  • Status check passes (green checkmark)

Notes

This is a test PR to validate our automated quality assurance process. If the GitHub Action works correctly, this demonstrates that future PRs will have reliable link validation.

🤖 Generated with Claude Code

- Create test-page.md with various link types to validate
- Include internal links (index.md, useful-resources.md)
- Include external links (github.com, python.org, sphinx-doc.org)
- Add test page to main index toctree
- This PR will test the automated link checking workflow functionality
@read-the-docs-community
Copy link

read-the-docs-community bot commented Jul 9, 2025

Documentation build overview

📚 wafer-space | 🛠️ build #28801995 (be0deb2) | 🔍 preview

Files changed

Comparing with latest (5f8d26f)

Show files (5) | 2 modified | 3 added | 0 deleted
File Status
README.html ➕ added
index.html 📝 modified
test-page.html ➕ added
useful-resources.html 📝 modified
.github/workflows/README.html ➕ added

- Add required permissions for commenting on PRs (pull-requests: write, issues: write)
- Fix ReadTheDocs URL pattern to use .org.readthedocs.build domain
- Update documentation to reflect correct URL pattern
- Resolves permission errors and incorrect URL construction
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🎉 Link Check Results - ✅ PASSED

ReadTheDocs Preview: https://wafer-space--16.org.readthedocs.build/en/16/

🎉 All links are valid!

The link checker found no broken links in your documentation.


Link check performed by muffet on commit c2bec38

mithro added 6 commits July 9, 2025 11:38
- Change timeout from '30s' to '30' (muffet expects integer seconds)
- Resolves 'invalid argument for flag -t, --timeout' error
- Remove unsupported flags: --user-agent, --color, --header, --one-page-only
- Keep core functionality: rate limiting, timeouts, exclusions
- Focus on basic link checking without advanced features
- Add realistic browser user agent to avoid 403 errors
- Add browser-like headers (Accept, Accept-Language, Accept-Encoding)
- Skip TLS verification to handle certificate issues
- Follow redirects automatically
- Increase timeout to 60 seconds for slow sites
- Reduce rate limit to 5 req/sec to be more respectful
- Add more exclusions for problematic sites (sourceforge, efabless, skywater)
- Update documentation to explain configuration choices

These changes address the common false positives in link checking:
- 403 Forbidden (crawler detection)
- Certificate errors (self-signed/expired certs)
- DNS timeouts (slow/unreliable sites)
- Redirect issues (not following redirects)
- Use --max-redirections instead of --follow-redirects
- Use --header flags instead of environment variables
- Add proper browser headers directly via --header
- Use --color=never for clean output
- Remove environment variables approach in favor of command-line flags

This should resolve the 'unknown flag' errors and properly configure
muffet to handle common link checking issues like:
- 403 Forbidden (realistic User-Agent header)
- Certificate errors (--skip-tls-verification)
- Redirects (--max-redirections=10)
- Timeouts (--timeout=60)
Link fixes:
- Replace broken GF180MCU PDK sub-pages with main documentation link
- Update OpenLane Workshop link to main OpenLane repository
- Remove broken Efabless IP catalog link, replace with community projects
- Replace broken Hackaday article with general IC testing resources

Exclusion improvements:
- Add allaboutcircuits.com (blocks crawlers)
- Add globalfoundries.com (corporate site blocks crawlers)
- Add klayout.de (slow/unreliable server)
- Update documentation to explain exclusions

These changes should resolve all remaining 403, 404, and timeout errors
while maintaining valuable reference links for users.
- Minor update to test page to trigger GitHub Action
- Previous commit fixed all broken links in useful-resources.md
- Should now pass with all links valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants