Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue470 adding nap classification to part5 #476

Merged
merged 7 commits into from
Dec 9, 2021

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Dec 2, 2021

See #470. This PR adds a first nap classification model that was trained in hip data from 3.5yr olds. Classified naps are added to the time series and part 5 csv report. Code is designed to allow for newer/better models to be added in the future.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #476 (ad3a402) into master (4a36175) will decrease coverage by 0.14%.
The diff coverage is 67.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   75.00%   74.85%   -0.15%     
==========================================
  Files          86       87       +1     
  Lines       10629    10705      +76     
==========================================
+ Hits         7972     8013      +41     
- Misses       2657     2692      +35     
Impacted Files Coverage Δ
R/g.part5.R 69.02% <62.94%> (-3.23%) ⬇️
R/g.part5.classifyNaps.R 90.62% <90.62%> (ø)
R/g.shell.GGIR.R 82.81% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a36175...ad3a402. Read the comment docs.

@vincentvanhees vincentvanhees merged commit cf24959 into master Dec 9, 2021
@vincentvanhees vincentvanhees deleted the issue470_nap_part5 branch December 22, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants