set daysleep_offset default value #399
Conversation
Default value of daysleep_offset was missing for single-midnight scenarios.
…nd 5 Errors and warnings collected during execution of parts 1,2,3 and 5 were only printed out when do.parallel=TRUE, and were unreported otherwise.
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 73.30% 74.55% +1.24%
==========================================
Files 77 80 +3
Lines 9584 9624 +40
==========================================
+ Hits 7026 7175 +149
+ Misses 2558 2449 -109
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank you Lena, this looks great and also runs without errors on my test files.
Do you want to add your name to the contributor list in the DESCRIPTION file?
Note that my criteria for being listed as a contributor are low: Anyone who has spent a bit of time trying to understand and improve the code is listed.
c() is equivalent to NULL, which is causing problems in the following line in `g.analyse.perfile.R`:
filesummary[vi:(vi+3)] = c(InterdailyStability, IntradailyVariability,
IVIS_windowsize_minutes, IVIS_epochsize_seconds)
The thing is, NULL is not allowed in a vector, and so it's getting ignored, and we end up with a vector size of 3 instead of 4. This causes a warning when Part2 is run:
"number of items to replace is not a multiple of replacement length"
NA doesn't have this problem and can be used to represent a missing value.
otherwise on the next line we get an error because if (NA == 'c()') is actually undefined.
The fact that the two statements are on the same line doesn't automatically group them into one block; only curly braces can that. Otherwise `do.anglez = TRUE` is always executed, for all values of `mode`.
|
Vincent -- I just added my name to the contributor list. If the changes look good to you, I think this is done for now. I would still like to re-write |
|
Sounds good, I will now merge this PR to the Master branch. |
Default value of daysleep_offset was missing for single-midnight scenarios.
This pull request will address #398