Issue361 axivitydemofile #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 74.21% 74.19% -0.02%
==========================================
Files 78 78
Lines 9493 9495 +2
==========================================
Hits 7045 7045
- Misses 2448 2450 +2
Continue to review full report at Codecov.
|
|
I've got some axivity files, will check during the weekend (sorry I've been too busy these days). |
|
I have run GGIR in some axivity files and did not find any issue, everything run smooth and results are coherent with previous estimates from the same files. Feel free to merge from my side. |
|
thanks Jairo |
This was referenced Oct 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #361, this fix makes that the .cwa demofile from the Axivity website can be processed again.
Additionally, I renamed object
frequencyfrom the g.cwaread function becausefrequencyis also a native R function, which could lead to future issues.@jhmigueles I am assuming that you do not work with Axivity data and/or are too busy at the moment to check this. So, I will merge this pull request myself after the weekend. If anyone working with Axivity data reads this and is interested to review this PR then feel free to do so.