fix: eliminate the possibility of NullPointerException (#56)

* fix: eliminate the possibility of NullPointerException * build: fix release build --------- Co-authored-by: Ryan Peper <ryan.peper@outlook.com>
wadahiro · Nov 2, 2024 · e2b5991 · e2b5991
1 parent d55eacf
commit e2b5991
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.releaserc b/.releaserc
@@ -9,7 +9,7 @@
     [
       "@terrestris/maven-semantic-release",
       {
-        "mavenTarget": "install",
+        "mavenTarget": "deploy",
         "clean": false,
         "updateSnapshotVersion": true,
         "settingsPath": "/home/runner/.m2/settings.xml",

diff --git a/pom.xml b/pom.xml
@@ -52,6 +52,13 @@
                     <target>17</target>
                 </configuration>
             </plugin>
+            <plugin>
+                <artifactId>maven-deploy-plugin</artifactId>
+                <version>3.1.3</version>
+                <configuration>
+                    <skip>true</skip>
+                </configuration>
+            </plugin>
         </plugins>
     </build>
 </project>
diff --git a/src/main/java/org/keycloak/social/discord/DiscordIdentityProvider.java b/src/main/java/org/keycloak/social/discord/DiscordIdentityProvider.java
@@ -71,9 +71,11 @@ protected BrokeredIdentityContext extractIdentityFromProfile(EventBuilder event,
 
         String username = getJsonProperty(profile, "username");
         String discriminator = getJsonProperty(profile, "discriminator");
-        if (!discriminator.equals("0")) {
-            username = username + "#" + discriminator;
+
+        if (!"0".equals(discriminator)) {
+            username += "#" + discriminator;
         }
+
         user.setUsername(username);
         user.setEmail(getJsonProperty(profile, "email"));
         user.setIdp(this);