Skip to content

CI: Create pull-request.yml #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2021
Merged

CI: Create pull-request.yml #157

merged 2 commits into from
Oct 8, 2021

Conversation

jorgebodega
Copy link
Collaborator

Add a pull request workflow to allow us to quickly filter by valid code.

Already checks:

  • Format
  • Lint
  • Typing
  • Tests

Update scripts from package.json


CI: Skip install on cache hit

CI: Skip install on cache hit

CI: Skip install on cache hit

CI: Add sample on workflow

CI: Use builtin node action on workflow
@jorgebodega jorgebodega self-assigned this Oct 7, 2021
Copy link
Collaborator

@RaphaelWoude RaphaelWoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@RaphaelWoude RaphaelWoude merged commit 3dfced6 into w3tecch:master Oct 8, 2021
@jorgebodega
Copy link
Collaborator Author

Well, I suppose it is ok, but I think we should discuss this between maintainers hahahaha

There is no unique way to do this, I usually use this kind of config at work, but I'm open to do some changes if it is necessary.

@jorgebodega jorgebodega deleted the github-ci-1 branch October 11, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants