-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coretime Lease Swap Instructions #6308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All nits, looks good!
`send` instruction of the XCM message: | ||
[0x4603e3070000320d0000](https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.ibp.network%2Fpolkadot#/extrinsics/decode/0x4603e3070000320d0000) | ||
|
||
![TX-payment-API-Lease-Swap](../assets/coretime/tx-payment-api-weights-lease-swap.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really its length should be provided since the screenshot also shows the partial fee, but here we're mostly interested in the weight so I get that it's not relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious. What value should be entered in len
field? Like the pre-image length of this call which is 10?
of their parachain. In order to place an order for on demand, any account must call the | ||
`onDemand.placeOrderAllowDeath` extrinsic. | ||
|
||
![onDemand-block-production](../assets/coretime/onDemand-block-production.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the screenshot included the params mentioned in the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only issue is what paraID to include, maybe we can add something like "your_para_id". And my OCD would also say with an updated metadata :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about the composable call included above, I think since that case is used up there we can use it throughout, or alternatively just have some fictitious swap between asset hub and bridge hub or something so people can see which numbers go where
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I'll go along with the composable example. This would be 2019 (the chain that is going to send the XCM call)
## Coretime Swap Prerequisites | ||
|
||
We need to ensure the parachains have a valid cores to execute the swap instruction. This can be | ||
achieved either by getting a core in bulk from the coretime system chain, or by leveraging the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also could be an ongoing lease (these are still respected by the coretime chain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things we saw since trying out the guide.
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Co-authored-by: Santi Balaguer <santiago.balaguer@gmail.com>
Co-authored-by: Santi Balaguer <santiago.balaguer@gmail.com>
@filippoweb3 The content has been reviewed. Please review and merge if the doc meets Wiki style guidelines. |
@DrW3RK can we change the slug from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Based on the guide https://hackmd.io/@ePxWAFa1TbKm0U5Ym3IqgQ/HkOFTfaykl