Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coretime Lease Swap Instructions #6308

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Coretime Lease Swap Instructions #6308

merged 8 commits into from
Oct 18, 2024

Conversation

DrW3RK
Copy link
Member

@DrW3RK DrW3RK commented Oct 17, 2024

@DrW3RK DrW3RK added the A1 - In Progress Not ready for review yet. label Oct 17, 2024
@DrW3RK DrW3RK self-assigned this Oct 17, 2024
@DrW3RK DrW3RK added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Oct 17, 2024
@DrW3RK DrW3RK requested a review from SBalaguer October 17, 2024 11:18
Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nits, looks good!

docs/learn/learn-guides-coretime-swap.md Outdated Show resolved Hide resolved
`send` instruction of the XCM message:
[0x4603e3070000320d0000](https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.ibp.network%2Fpolkadot#/extrinsics/decode/0x4603e3070000320d0000)

![TX-payment-API-Lease-Swap](../assets/coretime/tx-payment-api-weights-lease-swap.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really its length should be provided since the screenshot also shows the partial fee, but here we're mostly interested in the weight so I get that it's not relevant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. What value should be entered in len field? Like the pre-image length of this call which is 10?

of their parachain. In order to place an order for on demand, any account must call the
`onDemand.placeOrderAllowDeath` extrinsic.

![onDemand-block-production](../assets/coretime/onDemand-block-production.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the screenshot included the params mentioned in the doc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue is what paraID to include, maybe we can add something like "your_para_id". And my OCD would also say with an updated metadata :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the composable call included above, I think since that case is used up there we can use it throughout, or alternatively just have some fictitious swap between asset hub and bridge hub or something so people can see which numbers go where

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I'll go along with the composable example. This would be 2019 (the chain that is going to send the XCM call)

## Coretime Swap Prerequisites

We need to ensure the parachains have a valid cores to execute the swap instruction. This can be
achieved either by getting a core in bulk from the coretime system chain, or by leveraging the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could be an ongoing lease (these are still respected by the coretime chain)

Copy link
Contributor

@SBalaguer SBalaguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things we saw since trying out the guide.

docs/learn/learn-guides-coretime-swap.md Outdated Show resolved Hide resolved
docs/learn/learn-guides-coretime-swap.md Outdated Show resolved Hide resolved
DrW3RK and others added 5 commits October 17, 2024 17:29
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Co-authored-by: Santi Balaguer <santiago.balaguer@gmail.com>
Co-authored-by: Santi Balaguer <santiago.balaguer@gmail.com>
@DrW3RK
Copy link
Member Author

DrW3RK commented Oct 18, 2024

@filippoweb3 The content has been reviewed. Please review and merge if the doc meets Wiki style guidelines.

@filippoweb3
Copy link
Contributor

@DrW3RK can we change the slug from learn to build to match all other related docs and section? Also, doc name in the Wiki repo and doc position into the build folder?

Copy link
Contributor

@filippoweb3 filippoweb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@filippoweb3 filippoweb3 merged commit 4479f0f into master Oct 18, 2024
2 checks passed
@filippoweb3 filippoweb3 deleted the coretime-swap branch October 18, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants