Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move COFACTOR & COFACTOR_INV to ModelParameters #24

Merged

Conversation

mmagician
Copy link
Collaborator

Description

Our tests were broken after arkworks-rs#365.
This PR fixes these by moving the correct constants into the correct trait impl.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mmagician mmagician requested a review from drskalman December 30, 2021 16:17
@drskalman drskalman merged commit 2b14323 into w3f:hash_to_curve_wb Jan 6, 2022
@mmagician mmagician deleted the rebase-after-ec-models-refactor branch December 19, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants