Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refundable Subscription Mechanism #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refundable Subscription Mechanism #12

wants to merge 2 commits into from

Conversation

SaberDoTcodeR
Copy link

This PSP is related to our implementation of the SubsCrypt Project. This standard can be used in any token contract that supports built-in subscription methods.

@lamafab
Copy link
Contributor

lamafab commented Feb 16, 2022

Hi @SaberDoTcodeR, thanks for the PR.

  • It might be useful to specify the exact types of the parameters (reference).
  • There should probably be a more enhanced description about the concept of a "provider": in the Auth section you mentioned a "token" that should be used when hashing the password. I assume this is related to a identifier of a provider?
  • In the table, it would be convenient to indicate which function is used by the user and which one is used by the provider.

@lamafab lamafab added the awaiting-changes Waiting for upstream changes label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-changes Waiting for upstream changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaberDoTcodeR @lamafab