Skip to content

Added requested changes #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Added requested changes #501

merged 5 commits into from
Aug 2, 2021

Conversation

wstrametz
Copy link
Contributor

@wstrametz wstrametz commented Jul 19, 2021

Added requested (@alxs) changes - summary:

FIAT-on-off-ramp.md (this document):

  • Naming and documentation of methods which are shown in Swagger-UI
  • More specific (inline) documentation with external links related Ebics standard
  • Removed getBalance because balance is integrated getBankstatements statement

@alxs alxs self-assigned this Jul 19, 2021
@alxs
Copy link
Contributor

alxs commented Jul 20, 2021

Thanks for the update @wstrametz. I'm not sure how the current wrapper hides the complexities of Ebics, as far as I understand it the only difference is that one can call the API using a json file instead of XML?

Also could you please move the list of changes made to the delivery to the delivery PR?

@alxs alxs added the amendment This PR proposes changes to an existing application. label Jul 30, 2021
@alxs
Copy link
Contributor

alxs commented Jul 30, 2021

Following up on direct communications I'm sharing this with the rest of the committee. I've removed the list of changes made to the delivery (which can be found here) from your comment to facilitate the review of the amendment, hope that's okay. Also linking to the original application for reference #348.

@alxs alxs added the ready for review The project is ready to be reviewed by the committee members. label Jul 30, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wstrametz we recently updated the T&C, see #541. Could you sign the latest version? Otherwise it looks good.

@wstrametz
Copy link
Contributor Author

@wstrametz we recently updated the T&C, see #541. Could you sign the latest version? Otherwise it looks good.

Hi - just signed the licence - thanks a lot to the whole team for the input and the support!
walter

@mmagician mmagician merged commit 975e907 into w3f:master Aug 2, 2021
chrisli30 pushed a commit to AvaProtocol/W3F-Grants-Fork that referenced this pull request Oct 8, 2021
* add application

* feedback to CR

* added second feedback

* update - API getBalance

Co-authored-by: walter.strametz@gmail.com <walter.strametz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants