Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssemblyScript SCALE Codec Implementation #13

Merged
merged 6 commits into from
May 1, 2020
Merged

Conversation

Daniel-K-Ivanov
Copy link
Contributor

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below 30k at the time of submission.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2020

CLA assistant check
All committers have signed the CLA.

@RouvenP
Copy link
Contributor

RouvenP commented Apr 23, 2020

Hi @Daniel-K-Ivanov. Thanks for your application, looks fine from a financial point of view. The only change I have to request is the invoicing currency - we need the cost in BTC (fixed amount).

measure the costs in BTC
@Daniel-K-Ivanov
Copy link
Contributor Author

Hi @Daniel-K-Ivanov. Thanks for your application, looks fine from a financial point of view. The only change I have to request is the invoicing currency - we need the cost in BTC (fixed amount).

Hi @RouvenP. Thank you for the input. I've changed the invoicing currency into BTC. Hope that everything is okay in terms of the financial/costs.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the application. I’m reasonably happy with it and want to approve it, but could you potentially reduce the price a little bit more. I think 2 BTC for the SCALE codec implementation is relatively expensive (see for example the Java implementation, which we just signed: )

Reduce the costs to 1.8 by calculating the price based on the current BTC/USD pair.
@Daniel-K-Ivanov
Copy link
Contributor Author

Thanks again for the application. I’m reasonably happy with it and want to approve it, but could you potentially reduce the price a little bit more. I think 2 BTC for the SCALE codec implementation is relatively expensive (see for example the Java implementation, which we just signed: )

@Noc2 I understand your perspective. We've reduced the price to match the initial one which was deemed to be reasonable.

@Daniel-K-Ivanov Daniel-K-Ivanov requested a review from Noc2 April 24, 2020 06:56
Noc2
Noc2 previously approved these changes Apr 24, 2020
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the application. I still think it’s rather expensive (at least given the recent increase of the BTC price), but I’m willing to accept it at this stage, since there aren’t any other teams currently interested in it and you already put quite some effort into it.

keorn
keorn previously approved these changes Apr 27, 2020
Copy link
Contributor

@keorn keorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step towards AssemblyScript Runtimes

@RouvenP
Copy link
Contributor

RouvenP commented Apr 27, 2020

Thanks again for the application. I’m reasonably happy with it and want to approve it, but could you potentially reduce the price a little bit more. I think 2 BTC for the SCALE codec implementation is relatively expensive (see for example the Java implementation, which we just signed: )

@Noc2 I understand your perspective. We've reduced the price to match the initial one which was deemed to be reasonable.

@Daniel-K-Ivanov we usually look at what would be a reasonable rate in the country of incorporation and a daily rate per FTE of BTC 0.0706 (ca. $500 currently) seems fairly high for Bulgaria. do you think you can go further down? (sorry - missed to mention that in my initial comment)

Reduce the price to 1.5 BTC
@Daniel-K-Ivanov Daniel-K-Ivanov dismissed stale reviews from keorn and Noc2 via a0f586f April 28, 2020 07:57
@Daniel-K-Ivanov
Copy link
Contributor Author

Thanks again for the application. I’m reasonably happy with it and want to approve it, but could you potentially reduce the price a little bit more. I think 2 BTC for the SCALE codec implementation is relatively expensive (see for example the Java implementation, which we just signed: )

@Noc2 I understand your perspective. We've reduced the price to match the initial one which was deemed to be reasonable.

@Daniel-K-Ivanov we usually look at what would be a reasonable rate in the country of incorporation and a daily rate per FTE of BTC 0.0706 (ca. $500 currently) seems fairly high for Bulgaria. do you think you can go further down? (sorry - missed to mention that in my initial comment)

@RouvenP Thanks for the feedback. We’re excited to work on this and could drop the daily rate to about $450 (accounting for the latest price of BTC).

// cc @keorn @Noc2

@Daniel-K-Ivanov
Copy link
Contributor Author

Updated the BTC costs due to the surge in price and reduced the daily rate per FTE.

@Noc2 Noc2 requested a review from keorn April 30, 2020 17:26
@Noc2 Noc2 merged commit e409048 into w3f:master May 1, 2020
Noc2 pushed a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants