Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Bitcoin Vaults - Milestone #1 Delivery #451

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

mgravitt
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#868

15-minute video of milestone explainer and demonstration:
https://youtu.be/OYKvt-xir3E

@takahser
Copy link
Contributor

Thank you for the delivery, @3yekn! We will look into it as soon as possible.

@lucasvanmol lucasvanmol self-assigned this Jun 2, 2022
@lucasvanmol
Copy link
Contributor

Hi @3yekn. I'm trying to set an xpub with the UI, but when trying to scan a QR code the UI tells me to allow camera permissions. However, my browser never actually asks for it (this happened on Firefox, and then also on Chrome). Console error logs from Firefox:

Uncaught (in promise) TypeError: 'camera' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName.
    open qr-decode-xpub.vue:47
    ...

Additionally, trying to input an xpub manually does not seem to work as expected:

Screenshot 2022-06-03 at 11 21 08

Finally, https://github.com/hashed-io/native-bitcoin-vaults-UI is now 404'ing for me, has it been privated?

@mgravitt
Copy link
Contributor Author

mgravitt commented Jun 3, 2022

Hi @lucasvanmol - the XPUB format requires the fingerprint and the derivation path. It isn't clear from the error message though- I will create a new issue so that we put an example one on the screen. If you scan it in from BlueWallet (recommended), it will be the right format but we also support copy/paste of course.

The format should look like this:

[DDB3F11E/48'/0'/0'/2']Zpub74CJEA8Vx5yub6CiSuoFMLESzh2TzuaXXcZ4BrA9wntbg4kR9sCUrHqPQUCu5YMXRD6n624FUozZd8r5C41ProRqs3G6Mp2Zieu4RrWKdor

The camera error is a browser permission I believe. @jmgayosso - can you provide instructions on how to configure this?

And for the repo, it was inadvertently made private but it is public again now. Let me know if you would like me to generate some data for you or send tokens to your address if you are connecting to wss://n1.hashed.systems.

Unfortunately, BlueWallet does not have a testnet mode but we can create and fund a small multisig wallet with you for end-to-end testing if it helps.

@lucasvanmol
Copy link
Contributor

Would love some data for wss://n1.hashed.systems. Also, could you add appropriate LICENSE files to bdk-services, native-bitcoin-vaults-UI and nbv-ur-codec?

@mgravitt
Copy link
Contributor Author

mgravitt commented Jun 3, 2022

@lucasvanmol ok, I will create some data, vault/wallet, and we will also deploy an instance of the UI to make it easier to test. You will need to download BlueWallet though if you want to test importing the vault into a signer. This will also be needed for milestone 2, which includes signing the PSBTs and finalizing/broadcasting the transaction. I will report back when this is ready.

Also, I will update the LICENSE files as you mention. thanks

@mgravitt
Copy link
Contributor Author

mgravitt commented Jun 6, 2022

@lucasvanmol You can find a deployed instance at https://nbv.hashed.systems

Our substrate work is deployed at wss://n1.hashed.systems, which is where the UI points to.

I created a vault for two pretend users. I can send you to the mnemonics for those accounts. I pinged you on Element, and I can share them there.

I've also updated the LICENSE in all repos.

@lucasvanmol
Copy link
Contributor

Hi @3yekn, thank you for your patience and your help so far. Before we accept the delivery, we'd like to ask you for a few things:

  • Could you make sure the table included in this delivery is identical to the one in the application?
  • Could you edit the application document to include the changes you decided on, notably integrating BlueWallet instead of Spectre? Notably this section, and this one. You can edit them down quite a bit, just mention the technology you ended up going with.

Thanks!

@mgravitt
Copy link
Contributor Author

Hi @lucasvanmol, thanks for the update. I made the requested changes on this PR for the Delivery and submitted a new PR to the Grants-Program repo. That PR is located here: w3f/Grants-Program#987

@lucasvanmol
Copy link
Contributor

Thanks for the changes @3yekn ! You can see my final evaluation here. I'll notify the finance team to pay your invoice.

@lucasvanmol lucasvanmol merged commit 223ccc3 into w3f:master Jun 14, 2022
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

@RouvenP
Copy link

RouvenP commented Jul 12, 2022

hi @3yekn we transferred the BTC yesterday. Thanks!

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
* Update Polkadot-Dart.md

Adjust milestones plan.

* Update Polkadot-Dart.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants