-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CESS-2.md #330
Create CESS-2.md #330
Conversation
Hi, we changed the submission account because the previous account “CumulusSystem” has been changed to an organization account. In order to prove our identity, you can find our accounts under the organization of the original account. If you need us to provide more evidence, please don't hesitate to bring it up. Is there any way to pass the check? |
Hi @swowk. Thanks for the delivery. We will look into it as soon as possible. The check is for us to verify that at least one of the PR authors is the same as the application authors. This is mostly for us and our internal bookkeeping. Since you explained the issue, you can ignore the check. |
That's great, thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started to look into your delivery and noticed that a license file is missing here. Could you add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also regarding “CESS Contracts”. Could you create a PR to update the original application here and maybe also provide a little bit more details on why you choose to implement this as a pallet instead as part of the PR?
Sorry, we forgot to add it, it has been added now. |
Sure, thanks for the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for updating the original contract. I noticed that if I follow your testing guide, it doesn’t run any tests for pallet_segment_book. Could you fix this? Also at some point it would be nice if you could write an article and share it with grantspr@web3.foundatio. But it is not mandatory for the acceptance of this milestone.
We apologize for making this error, and it has now been corrected. Besides, we are willing to write an article, but I am a little confused about what the topic of the article should be? Could you please hint more details? thank you. @Noc2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I’m happy to tell you that the milestone is a pass and I will forward your invoice internally. You can find my evaluation here. Regarding the article, this is basically up to you. But you might want to announce for example the progress you made as part of this milestone or something similar.
hi @swowk, we transferred the payment today. Thanks! |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#595