Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHACL validation errors #1966

Merged
merged 6 commits into from
Feb 9, 2024
Merged

SHACL validation errors #1966

merged 6 commits into from
Feb 9, 2024

Conversation

mahdanoura
Copy link
Contributor

@mahdanoura mahdanoura commented Feb 2, 2024

addresses #1345


Preview | Diff

index.html Show resolved Hide resolved
Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR itself is fine but we will check the tooling before merging. This will happen asynchronously.

@egekorkan egekorkan merged commit 0d99bfb into w3c:main Feb 9, 2024
1 check passed
@@ -32,7 +32,7 @@
a text for UI representation) based on a default
language."""^^rdf:HTML ;
sh:nodeKind sh:Literal ;
sh:datatype rdf:langString ;
sh:or ( [ sh:datatype xsd:string ] [ sh:datatype rdf:langString ] ) ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was apparently not correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember wrestling with something like this, maybe the comments #1684 can help @mahdanoura or @egekorkan .

@mahdanoura mahdanoura deleted the shacl-validation branch February 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants