Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and reword Security section #124

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Move and reword Security section #124

merged 3 commits into from
Mar 2, 2022

Conversation

benfrancis
Copy link
Member

@benfrancis benfrancis commented Nov 9, 2021

As originally proposed in #73 (comment) and #78 this PR moves the Security section out of the WoT Core Data Model section into its own section within Core Profile.

I've also refined the wording of the normative statements and added references to the WoT Thing Description and WoT Security Security Best Practices documents.


Preview | Diff


Preview | Diff

@mlagally
Copy link
Contributor

I'm getting more and more concerned by MRs that contain textual and structural changes in a single MR.
They require significant time to review, since there's no useful diff.
Please refactor into a MR that only proposes the text changes.
If you also want to propose structural changes of the document, please create a separate MR.

@benfrancis
Copy link
Member Author

@mlagally When I split the large PR into six separate PRs, the reason that I kept these changes together is that the one change builds on the other, which means that two separate PRs would cause a merge conflict.

I've now split this PR into two separate commits so you can see the diffs separately, but I'm not sure it actually makes much difference.

@mlagally mlagally merged commit 3ea03d9 into w3c:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants