Add support for long keyID values #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
commented
Mar 11, 2021
|
@martinthomson does this look good to you? |
martinthomson
approved these changes
Mar 12, 2021
youennf
commented
Mar 18, 2021
youennf
commented
Mar 18, 2021
|
@dontcallmedom any idea how to handle BigInt missing reference? |
dontcallmedom
added a commit
to dontcallmedom/widlparser
that referenced
this pull request
Mar 18, 2021
|
The right fix is to get bikeshed to recognize it, which itself require a fix in tis WebIDL parser - I've filed a pull request towards that: plinss/widlparser#64 I think temporarily you can defined BigInt as a local anchor with type interface to workaround the problem while this gets fixed. |
Co-authored-by: Martin Thomson <mt@lowentropy.net>
dontcallmedom
force-pushed
the
long-keyID-values
branch
from
f435700 to
ea708f9
Compare
|
This PR was discussed during Thursday editor's call and deemed ready to merge once the WebIDL BigInt issue is fixed. |
|
Checks are fine, so merging. |
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2021
…for long keyID values* Update index.bsCo-authored-by: Martin Thomson <mt@lowentropy.net>* Update index.bs* Update index.bs* Add BigInt workaround* BigInt link fixCo-authored-by: Martin Thomson <mt@lowentropy.net> SHA: 566cd58 Reason: push, by @youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
foolip
added a commit
to w3c/webref
that referenced
this pull request
Mar 23, 2021
Added to Web IDL in whatwg/webidl#525 but now used (with wrong case) in w3c/webrtc-encoded-transform#77.
foolip
added a commit
to foolip/webrtc-insertable-streams
that referenced
this pull request
Mar 23, 2021
Introduced in w3c#77 Per https://heycam.github.io/webidl/#idl-bigint the type is spelled "bigint". This isn't used in any other spec yet, but there are examples of this in tests: https://github.com/w3c/webidl2.js/blob/9e8b5a0247f2cffccc6265c6577f98a0883d3a60/test/syntax/idl/bigint.webidl
foolip
reviewed
Mar 23, 2021
| @@ -191,10 +194,13 @@ dictionary SFrameTransformOptions { | |||
| SFrameTransformRole role = "encrypt"; | |||
| }; | |||
|
|
|||
| typedef [EnforceRange] unsigned long long SmallCryptoKeyID; | |||
| typedef (SmallCryptoKeyID or BigInt) CryptoKeyID; | |||
There was a problem hiding this comment.
I've sent #92 to fix the case of BigInt here, spotted by tests in https://github.com/w3c/webref.
youennf
pushed a commit
that referenced
this pull request
Mar 23, 2021
Introduced in #77 Per https://heycam.github.io/webidl/#idl-bigint the type is spelled "bigint". This isn't used in any other spec yet, but there are examples of this in tests: https://github.com/w3c/webidl2.js/blob/9e8b5a0247f2cffccc6265c6577f98a0883d3a60/test/syntax/idl/bigint.webidl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Preview | Diff