Skip to content

Support bigint arrays as keywords #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2021
Merged

Support bigint arrays as keywords #601

merged 3 commits into from
Jul 4, 2021

Conversation

saschanaz
Copy link
Member

This patch closes #600 and includes:

  • A relevant test
  • A relevant documentation update (N/A)

@saschanaz saschanaz requested a review from marcoscaceres July 1, 2021 16:40
@saschanaz saschanaz marked this pull request as draft July 1, 2021 16:40
@saschanaz
Copy link
Member Author

Pending for whatwg/webidl#936

undefined add(Float32Array view);
undefined add(Float64Array view);

undefined addAny(BufferSource source);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, there's also ArrayBufferView, which like BufferSource is not a keyword.

@TimothyGu
Copy link
Member

whatwg/webidl#936 is merged :)

@saschanaz saschanaz marked this pull request as ready for review July 1, 2021 22:23
@saschanaz saschanaz merged commit 92ccea9 into main Jul 4, 2021
@saschanaz saschanaz deleted the bigint2 branch July 4, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BigInt64Array and BigUint64Array types
2 participants