Add a Pass Through command for use by intermediary nodes
#825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a straw man that I intend to beat into shape using review comments. Be less than gentle. |
|
Depends on #824 in order to not introduce ReSpec errors. |
This is required to allow an intermediary node to send commands upstream.
shs96c
force-pushed
the
intermediary-pass-thru
branch
from
7dc7aac
to
480ef24
Compare
AutomatedTester
requested changes
Mar 3, 2017
| this command was called with. How this is done is outside the scope | ||
| of this specification. | ||
|
|
||
| <p class=issue>Set the headers of the HTTP request. |
There was a problem hiding this comment.
We should just copy them from command to command here.
| <li><p>Let <var>data</var> be the result of <a data-lt="json | ||
| serialization">serializing as JSON</a> <var>parameters</var>. | ||
|
|
||
| <p class=note>This must create a JSON <a>Object</a> that is |
There was a problem hiding this comment.
We should just call <a>clone an object</a> here that will be passed through
|
@shs96c wanna finish this off or close it? |
|
I do want to finish it. |
|
Per the testing policy, this PR can't be accepted without a corresponding test in the web-platform-tests repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to allow an intermediary node to send
commands upstream.
This change is