-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input events dispatch to top-level frame #1847
base: master
Are you sure you want to change the base?
Conversation
@whimboo WDYT? |
The following two things seem to be still missing:
|
Yes, absolutely. By changing the way where we dispatch the events the coordinates should be exactly the same. Not taking care of offsets would cause quite a lot of regressions for those users who make use of actions a lot. Therefore see: web-platform-tests/wpt#48147 Given that Chrome seems to already dispatch actions in the top-level browsing context the referenced tests are failing.
Yes, we would have to do it for all the pointer and wheel input sources. Keyboard actions are more challenging because they could allow users to trigger shortcuts that access restricted browser features. This would require additional checks to determine what actions are permitted and which ones should be blocked. Maybe we should have a follow-up issue for it? |
As discussed in w3c/webdriver-bidi#795, the actions should be dispatched from the top-level browsing context.
Preview | Diff