Remove normative descriptions #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description is duplicated by the remote ends steps. It says exactly the same things.
This command's description is slightly misleading and doesn't really explain what happens. It can be useful to point out that it selects which browsing context will be the target for all subsequent commands. Also merges note in the remote end steps.
The description is self-explanatory.
andreastt
requested review from
AutomatedTester,
jgraham and
shs96c
as code owners
AutomatedTester
approved these changes
Feb 22, 2018
|
|
||
| <p> | ||
| For example, consider this pseudo code | ||
| which retrieves an element with the <code>#toremove</code> ID |
There was a problem hiding this comment.
This would be better with an html example since we don't say what an ID is.
There was a problem hiding this comment.
Mind if I file a follow-up to improve command introductions and examples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #1105 to remove/improve/adapt command descriptions that could be mistaken as normative.
Preview | Diff