-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we rename browser name/browser version to be targeted towards the platform #1243
Comments
While I see the primary use is for browsers it's also mainly for the rendering engine of the browser, as WebDriver makes no effort to test the UI (however remote ends have implemented their own WebDriver API surface to test the UI like Firefox). I think it might be a good idea to make this the rendering engine being targeted but that might only work with our architecture and not others. |
What's the concrete suggestion here? Neither Cloud providers already suggest people put something different in their new session payloads, and things like Appium have already suggested using different fields. |
While it's not called out in the New Session command, it is called out as having a default to be compared to in the Match Capabilities section. Maybe that section should just be updated to include that the defaults can be null (it certainly can be interpreted that way but they seem required on first read). |
Which defaults do you refer to? Those assigned to matched capabilities in step 1? The point of the matching algorithm is that these can never be null, but produce an effective dictionary of capabilities after input validation of the capabilities given by the user. |
True but that also makes them defaults, so we end up having two sections where we specify default capabilities. Match to validate and then New Session to also validate. Seems like this could be one section that handles both (possibly moving the default capabilities in New Session into Match). |
MicrosoftWebDriver.exe can be used to test both the Edge browser as well as any apps that are either a Windows Web App (WWA) or contain a WebView. It seems odd then that a developer would specify a browser name when they're testing their WWA or the WebView within their UWP.
I imagine similar issues arise for ChromeDriver targeting Android WebViews and the like. What are peoples thoughts on this?
The text was updated successfully, but these errors were encountered: