Add scripts used to generate test vectors #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
selfissued
approved these changes
May 6, 2025
github-actions bot
added a commit
that referenced
this pull request
May 7, 2025
SHA: 86e50a9 Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #2281.
#2209 added test vectors, and I said that:
Most of this upstreaming is now resolved, so this PR adds a cleaned-up version of the scripts used to generate test vectors.
This also revealed a mistake in the documentation of how the
salt_encIV values were generated: the were generated with seed suffixes0x06and0x07, not0x07and0x08. Commit 9464903 first fixes the description to match the test vectors, and commit 87cab44 then reverts to the original description and instead updates the test vectors to match.Preview | Diff