Handle the AbortSignal in get() and create() themselves. #110
Conversation
And remove WebAuthn-specific text. Thanks to AngeloKai for the basis of this change.
Instead of by the definition of the internal methods.
mikewest
left a comment
mikewest
left a comment
There was a problem hiding this comment.
This looks good to me, with one nit about pulling WebAuthn in as a normative reference. If that requires changes to Bikeshed, then I'd be happy to just land this and deal with it later (though probably with a comment in the text that we should come back to this).
| [=credentials=] that need to be re-generated from a [=credential source=]. | ||
|
|
||
| Long-running operations, like those in {{PublicKeyCredential}}'s | ||
| {{PublicKeyCredential/[[Create]](options)}} and {{PublicKeyCredential/[[DiscoverFromExternalSource]](options)}} |
There was a problem hiding this comment.
Nit: This causes Bikeshed to pull WebAuthn in as a normative reference, which I don't think we actually want. That said, I'm not sure how to tell Bikeshed that it's an informative reference. :) @tabatkins might have some ideas? :)
There was a problem hiding this comment.
Whoops. https://tabatkins.github.io/bikeshed/#auto-biblio says how to avoid it. Done.
|
LGTM, thanks! I'll merge it once Travis is done poking at it. |
3 participants
This builds on #104 (Thanks @AngeloKai!) and now follows the instructions in https://dom.spec.whatwg.org/#abortcontroller-api-integration to bail out early if the caller has already aborted before the operation starts.
8c46783 shows two approaches to explaining how the internal methods use the AbortSignal. Let me know which you prefer.
Preview | Diff