This repository was archived by the owner on Jun 7, 2018. It is now read-only.
Remove text for handling 'non interpolable' values #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we define interpolation and addition for all property value types, the algorithm for evaluating a keyframe animation effect should no longer explicitly handle types which are 'not interpolable'.
|
The whole of section 4 needs to be reworked. I've started reworking 4.6 so it doesn't overlap with 4.1 so much but we still have the concepts of interpolable and additive in 4.1.2. It's a big job; something I'll probably tackle after FPWD. I'm somewhat inclined to leave this until after FPWD and fix it properly then. |
|
I wanted to make this fix now as we're updating the polyfill to match the FPWD spec. This text is wrong and I think it's safe to remove it. Also, to avoid duplicated effort, note that I have a post-FPWD re-write of keyframe animation effects in #4 |
|
Ok, sounds fine then. |
|
Merged in: https://dvcs.w3.org/hg/FXTF/rev/ce7b5d6f46cc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we define interpolation and addition for all property value types, the
algorithm for evaluating a keyframe animation effect should no longer
explicitly handle types which are 'not interpolable'.