Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test old reports on compatibility #1

Closed
mhansma96 opened this issue Jun 28, 2021 · 6 comments
Closed

Test old reports on compatibility #1

mhansma96 opened this issue Jun 28, 2021 · 6 comments
Assignees
Labels
qa Things related to testing

Comments

@mhansma96
Copy link
Collaborator

Old reports have a different JSON format and within the import-fuction all kinds of things will give errors because some keys don't exist in exports from the old tool

@mhansma96 mhansma96 changed the title Old reports with different JSON structure cannot be imported [Redesign] Old reports with different JSON structure cannot be imported Jun 28, 2021
@mhansma96 mhansma96 changed the title [Redesign] Old reports with different JSON structure cannot be imported [Redesign] Test old reports on compatibility Jun 28, 2021
@mhansma96
Copy link
Collaborator Author

I've made some changes that should make it possible for old reports to be imported. But I do lack some old reports or older knowledge of potential scenario's that can fail. We should try to test a few more reports on their compatibility with the new tool after an import. Preferably reports from the old tool. @hidde @nitedog

@hidde
Copy link
Member

hidde commented Jun 29, 2021

Great, thanks for those changes, Michel!

We should try to test a few more reports on their compatibility with the new tool after an import. Preferably reports from the old tool.

Agreed. @nitedog do you have any old reports we could use for testing this?

@nitedog
Copy link
Contributor

nitedog commented Jun 29, 2021

No, unfortunately not anymore. Maybe EricV can get some anonymized reports from ACC?

@hidde hidde transferred this issue from w3c/wcag-em-report-tool Jun 29, 2021
@hidde hidde changed the title [Redesign] Test old reports on compatibility Test old reports on compatibility Jun 29, 2021
@hidde hidde added the qa Things related to testing label Jun 29, 2021
@hidde
Copy link
Member

hidde commented Jun 30, 2021

Michel and Hidde discussed: Hidde to ask around for old reports.

@hidde hidde self-assigned this Jun 30, 2021
@ghost
Copy link

ghost commented Jul 1, 2021

hey there 👋

For what it is worth:

I have tested backward compatibility with the examples provided in the docs here: https://github.com/w3c/wcag-em-report-tool/tree/master/docs/examples

To test compatibility with previous versions you dont need full reports allthough it is nice to have for more realistic testing. Things to check are:

  • Criteria with changed hash urls (id's) wcag 2.0 <> 2.1
  • Nested results (sample / page level observations in step 4)
  • Simple data like scope, explore etcetera.

There are 2 previous versions viewable online:

You can easily create a simple export with each version if you require quick sample data and test compatibility with this version of the tool.

To prevent possible future conflicts I have set up exporting with the jsonld.js API, so at least the json-ld syntax will be compliant. This also helps importability since you should be able to frame any required earl data (assertions, tests, subjects)

All data compatibility checks are done at

async open(openedEvaluation) {

Object @contexts are created in model.js files like in https://github.com/w3c/wai-wcag-em-report-tool/blob/main/src/stores/earl/subjectStore/models.js which affects what data is exported and matched against from imported / opened json-ld files. This means json-ld @context

NOTE: Important though is to be consistent with @context defined IRI's like "WCAG21": "http://www.w3.org/TR/WCAG21/#" and keep using http protocol there. Unknown json-ld data (used for importing observations at step 4) should have their json-ld @context mapped / resolved to using the same protocol, otherwise there will be mismatches (http !== https)

I recommend, if you have not already, to read and play with json-ld to get a little understanding on how the tool's data is structured:
https://json-ld.org/

Hope this will help.

@hidde
Copy link
Member

hidde commented Jul 7, 2021

Thanks @rvantonisse for all this context!

We've been able to access some real life old reports and tested with those.

@hidde hidde closed this as completed Jul 7, 2021
remibetin pushed a commit that referenced this issue Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Things related to testing
Projects
None yet
Development

No branches or pull requests

3 participants