Stopgap fix for broken feed display images #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kyll build system when deployed
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I've verified this should render the images as expected, when deployed, with a local build of |
alflennik
approved these changes
May 31, 2023
mcking65
requested changes
Jun 5, 2023
There was a problem hiding this comment.
This seems like a reasonable stopgap, but I'd like to include tracking of an issue to remove it. I think we will remove it when we have a fix on the content side. Not sure that is worthwhile to fix it on the build side ... supporting this capability is unnecessary complexity.
mcking65
changed the title
mcking65
approved these changes
Jun 8, 2023
|
Thank you @howard-e! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for broken feed display example images, until further research is done into packaging the assets together for the Jekyll build system. Inspired by w3c/aria-practices#2705
Related issues:
Link to deploy preview's feed-display example page