Remove ProblemDetail integer error codes. #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
BigBlueHat,
davidlehn,
dlongley,
iherman,
dmitrizagidulin,
David-Chadwick,
decentralgabe,
KDean-Dolphin,
brentzundel and
PatStLouis
dlongley
approved these changes
Sep 16, 2024
iherman
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
I presume there should be a similar change for the DI spec processing errors.
Yes, if this PR goes through, I'll just remove the errors in the other specs on main since, at that point, those changes will be purely editorial in order to align them with this specification. |
decentralgabe
approved these changes
Sep 16, 2024
BigBlueHat
approved these changes
Sep 18, 2024
|
Normative, multiple reviews, no changes requested, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #1559 by removing integer error codes in the ProblemDetails objects.
Preview | Diff