Do some editorial adjustments to the Sensor algorithms. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
force-pushed
the
algorithm-proof-reading
branch
from
861bc7d
to
418f7df
Compare
- Use Web IDL's definition conventions for methods and getters (whatwg/webidl#882): - Describe getters as "The attr getter steps are [...]". - Describe methods as "The myMethod(arg) method steps are [...]". - Refer to [=this=] as defined in Web IDL rather than a concept that was not defined anywhere. - Use [=this=] rather than the `sensor_instance` variable where possible, as the latter was not defined anywhere. - When invoking the "notify error" abstract operation, pass the arguments in the order expected by the operation.
rakuco
force-pushed
the
algorithm-proof-reading
branch
from
418f7df
to
90cee3f
Compare
reillyeon
approved these changes
Dec 13, 2021
| Gets the {{DOMException}} object passed to {{SensorErrorEventInit}}. | ||
| The {{SensorErrorEvent/error!!attribute}} getter steps are to return the value it was initialized to. | ||
|
|
||
| It represents the {{DOMException}} object passed to {{SensorErrorEventInit}}. |
There was a problem hiding this comment.
As a follow-up we should really properly specify the constructor algorithm and internal slots for SensorErrorEvent instead of this hand-wavy description.
There was a problem hiding this comment.
Agreed, I opened an issue for that: #426
anssiko
approved these changes
Dec 14, 2021
| Gets the {{DOMException}} object passed to {{SensorErrorEventInit}}. | ||
| The {{SensorErrorEvent/error!!attribute}} getter steps are to return the value it was initialized to. | ||
|
|
||
| It represents the {{DOMException}} object passed to {{SensorErrorEventInit}}. |
There was a problem hiding this comment.
Agreed, I opened an issue for that: #426
|
@rakuco, thanks for this PR, I'll merge this now and we can handle any follow-ups later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Web IDL's definition conventions for methods and
getters (Define definition conventions whatwg/webidl#882):
Refer to [=this=] as defined in Web IDL rather than a concept that was not
defined anywhere.
Use [=this=] rather than the
sensor_instancevariable where possible, asthe latter was not defined anywhere.
When invoking the "notify error" abstract operation, pass the arguments in
the order expected by the operation.
Preview | Diff