Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup priv-sec wording + recommend an indicator #323

Merged
merged 5 commits into from
Sep 30, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Aug 26, 2021

Closes #282


Preview | Diff

index.html Outdated Show resolved Hide resolved
@rakuco rakuco requested a review from reillyeon August 26, 2021 08:23
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
</h2>
<p>
The `"screen-wake-lock"` <a>powerful feature</a> defines a
<a>permission revocation algorithm</a>. To invoke the <dfn>Screen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started referencing the "permission revocation algorithm" in #297 to make sure this was properly integrated with the Permissions API spec. The new "revoke the screen-wake-lock permission" definition above is not referenced anywhere and it's not clear how it would integrate with the Permissions API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Permissions API provides a permission revocation algorithm hook for specifications to take action when a permission is revoked. The definition above should be declared as the permission revocation algorithm for the "screen-wake-lock" permission.

index.html Outdated Show resolved Hide resolved
index.html Outdated
</h2>
<p>
The `"screen-wake-lock"` <a>powerful feature</a> defines a
<a>permission revocation algorithm</a>. To invoke the <dfn>Screen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Permissions API provides a permission revocation algorithm hook for specifications to take action when a permission is revoked. The definition above should be declared as the permission revocation algorithm for the "screen-wake-lock" permission.

@marcoscaceres marcoscaceres changed the title Editorial: cleanup priv/sec/permissions Cleanup priv sec wording + recommend an indicator Sep 9, 2021
@marcoscaceres marcoscaceres changed the title Cleanup priv sec wording + recommend an indicator Cleanup priv-sec wording + recommend an indicator Sep 9, 2021
@marcoscaceres marcoscaceres requested review from rakuco and reillyeon and removed request for kenchris September 9, 2021 04:52
@marcoscaceres
Copy link
Member Author

sorry for my screwup on this PR! Now only deals with #282.

Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It'd be good for either @David-Chadwick or @reillyeon to take another look as well.

index.html Outdated Show resolved Hide resolved
Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM with the caveat that Chromium currently chooses not to implement an explicit notification that a site is holding a screen wake lock as our Security UX team believes that it is sufficiently obvious from the fact that the device's screen remains on.

index.html Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member Author

This LGTM with the caveat that Chromium currently chooses not to implement an explicit notification that a site is holding a screen wake lock as our Security UX team believes that it is sufficiently obvious from the fact that the device's screen remains on.

I think that's fine. I'm sure if it becomes an issue, users will get notified one way or another.

@marcoscaceres marcoscaceres merged commit 0080849 into gh-pages Sep 30, 2021
@marcoscaceres marcoscaceres deleted the sec_wording branch September 30, 2021 03:36
@xfq xfq mentioned this pull request Sep 30, 2021
15 tasks
rakuco added a commit to rakuco/wake-lock that referenced this pull request Oct 6, 2021
…level.

Follow-up to commit 0080849 ('Cleanup priv-sec wording + recommend an
indicator (w3c#323)').

@David-Chadwick suggested adding this part of the original text back because
it is still relevant (see w3c#323).
rakuco added a commit that referenced this pull request Oct 7, 2021
…level. (#328)

Follow-up to commit 0080849 ('Cleanup priv-sec wording + recommend an
indicator (#323)').

@David-Chadwick suggested adding this part of the original text back because
it is still relevant (see #323).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend some UI indicator for when wake lock is active
4 participants