Well-known Web IDL types: Drop Error, RegExp and DOMException #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #771 took care of most Web IDL types that are defined in the Web IDL spec as actual IDL interfaces, except `DOMException`. It appears 24 times across all specs, that seems like a good dependency to track as well (and not too noisy). `Error` and `RegExp` are not valid Web IDL types, so not sure why they were added to the list of well-known Web IDL types in the first place! This would fix #516. Automation seems overkill for that.
dontcallmedom
approved these changes
Apr 27, 2022
tidoust
added a commit
that referenced
this pull request
Apr 29, 2022
Dependencies bumped: - Bump puppeteer from 13.6.0 to 13.7.0 (#933) - Bump web-specs from 2.8.0 to 2.9.0 (#934) - Bump respec from 32.1.3 to 32.1.4 (#928) Bug fixes: - Well-known Web IDL types: Drop Error, RegExp and DOMException (#931) - IDL extraction: drop check on NoInterfaceObject (#930) - Ignore comment lines in CSS value space definitions (#929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #771 took care of most Web IDL types that are defined in the Web IDL spec as actual IDL interfaces, except
DOMException. It appears 24 times across all specs, that seems like a good dependency to track as well (and not too noisy).ErrorandRegExpare not valid Web IDL types, so not sure why they were added to the list of well-known Web IDL types in the first place!This would fix #516. Automation seems overkill for that.