Normalize newlines when slicing IDL extracts text #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDL extracts are generated using `\n` as newline delimiter. However, platform-specific newlines may be introduced during curation when patches are applied, meaning that, on Windows, curated extracts may end up with a mix of `\n` and `\r\n` characters. This confused the code that read the extracts and dropped the header. The code now normalizes all newlines to `\n` before it slices the content.
dontcallmedom
approved these changes
Sep 12, 2024
tidoust
added a commit
that referenced
this pull request
Oct 7, 2024
Code patched: - Normalize newlines when slicing IDL extracts text (#1669) Dependencies bumped: - Bump rollup from 4.21.2 to 4.24.0 (#1680) - Bump web-specs from 3.21.0 to 3.23.0 (#1683) - Bump serve-static from 1.15.0 to 1.16.2 (#1671) - Bump respec from 35.1.1 to 35.1.2 (#1668) - Bump puppeteer from 23.3.0 to 23.5.0 (#1681)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDL extracts are generated using
\nas newline delimiter. However, platform-specific newlines may be introduced during curation when patches are applied, meaning that, on Windows, curated extracts may end up with a mix of\nand\r\ncharacters. This confused the code that read the extracts and dropped the header.The code now normalizes all newlines to
\nbefore it slices the content.