[algorithms] Fix handling of sub-steps #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple of cases where algorithm extraction got confused while parsing sub-steps, either because another sub-step had a `<dfn>` or because the logic recursively went back to the root of the algorithm instead of stopping at the parent step.
dontcallmedom
approved these changes
Jul 22, 2024
tidoust
added a commit
that referenced
this pull request
Jul 23, 2024
Bug fix: - [algorithms] Fix handling of sub-steps (#1626) Dependencies bumps: - Bump ajv from 8.16.0 to 8.17.1 (#1620) - Bump mocha from 10.6.0 to 10.7.0 (#1624) - Bump undici from 6.19.2 to 6.19.4 (#1627) - Bump semver from 7.6.2 to 7.6.3 (#1622) - Bump puppeteer from 22.13.0 to 22.13.1 (#1621) - Bump rollup from 4.18.1 to 4.19.0 (#1625)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of cases where algorithm extraction got confused while parsing sub-steps, either because another sub-step had a
<dfn>or because the logic recursively went back to the root of the algorithm instead of stopping at the parent step.