Skip to content

Commit

Permalink
Fix Puppeteer instance teardown (#1586)
Browse files Browse the repository at this point in the history
The code was not waiting for the browser instance to get properly closed. That
did not affect the result of the crawl, but the OS could report an error
message such as "A child process was not properly killed" when the crawl
command exited.
  • Loading branch information
tidoust authored Jun 6, 2024
1 parent de7c50b commit a0c9bda
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lib/specs-crawler.js
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ async function crawlList(speclist, crawlOptions) {

// Close Puppeteer instance
if (!crawlOptions.useCrawl) {
teardownBrowser();
await teardownBrowser();
}

return results;
Expand Down

0 comments on commit a0c9bda

Please sign in to comment.