Skip to content

Conversation

@chrisn
Copy link
Member

@chrisn chrisn commented Jun 24, 2025

See #312


Preview | Diff

@marcoscaceres
Copy link
Member

Having multiple files seems sub optimal, as the description will likely fall out of sync. Can we instead just throw the relevant information into a <details> element? Also, the information should be written to be suitable for all audiences, not specifically for someone using assistive technology (it seems somewhat excessive in its description).

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks for addressing the issue!

</p>
<figure>
<a href=
'https://w3c.github.io/media-source/pipeline_model_description.html#pipelinedesc'><picture><img src="pipeline_model.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the spec-prod action used not to support automatic publication of local HTML assets linked from a spec, and the absolute URL was thus needed (the file does not exist under www.w3.org/TR yet). But that's no longer the case, that feature got added to spec-prod 3 years ago (and I of course forgot to update the URL in MSE accordingly!).

@tidoust
Copy link
Member

tidoust commented Jun 25, 2025

Hadn't seen @marcoscaceres's comment before I reviewed. This PR has the advantage of using a consistent scheme and approach for both images in the spec, but I don't disagree that the description (in both cases) seems excessive and would better be integrated within the main spec. Up to you :)

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move what we can into the main document. Having these kind of linked descriptions don't make a lot of sense and can quickly get out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants