-
Couldn't load subscription status.
- Fork 57
Add image description text for the audio splice rendering image #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Having multiple files seems sub optimal, as the description will likely fall out of sync. Can we instead just throw the relevant information into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me, thanks for addressing the issue!
| </p> | ||
| <figure> | ||
| <a href= | ||
| 'https://w3c.github.io/media-source/pipeline_model_description.html#pipelinedesc'><picture><img src="pipeline_model.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, the spec-prod action used not to support automatic publication of local HTML assets linked from a spec, and the absolute URL was thus needed (the file does not exist under www.w3.org/TR yet). But that's no longer the case, that feature got added to spec-prod 3 years ago (and I of course forgot to update the URL in MSE accordingly!).
|
Hadn't seen @marcoscaceres's comment before I reviewed. This PR has the advantage of using a consistent scheme and approach for both images in the spec, but I don't disagree that the description (in both cases) seems excessive and would better be integrated within the main spec. Up to you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move what we can into the main document. Having these kind of linked descriptions don't make a lot of sense and can quickly get out of sync.
See #312
Preview | Diff