-
Notifications
You must be signed in to change notification settings - Fork 32
Add pm wg weekly digest #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Well, looks like this is a bust. I see in the schema now that we can't use |
can you say a bit more what you mean by including "comments" in the digest? here was a digest currently looks like: https://lists.w3.org/Archives/Public/public-webrtc/2025Apr/0008.html |
I expect it would be like this line: "1 issues received 7 new comments:" Along with the new issue and pull requests, it would be helpful to give people notice of where new discussions are going on in the tracker. I just can't figure out how to combine those non-filtered "new" events with also selectively wanting to highlight the issues/prs that are being labeled as moving to final review. |
A possibility would be to have two separate digests, one for regular activity and one focused on final review |
@iherman @wareid @shiestyle Any preference on how to move forward? Two digests the same day, two on separate days, or only one with final review items? |
I have a mild preference for two digests on the same day to emphasize the "final" ones, but I realize it is a bit of a drag for people. @wareid @shiestyle? |
I think the revised pull request will do what we want now, with final review updates coming Thursday and non-final review updates on Friday. @dontcallmedom Just to confirm, if the only thing that changes for the week is that an issue or pull request gets labelled "Final Review" the digest will pick that up? In other words, if it's not a new issue or pull request with the label and there aren't any new comments, the act of labelling alone won't be ignored? |
@mattgarrish good callout! I'm afraid you're right that the event filter won't achieve what you want now that you mention it. You can get "live" email notifications sent when a label is set, but that doesn't translate into how the digests are built. Looking quickly at the code, I think it shouldn't be too difficult to add that as a feature, but it won't be available until I (or some other good soul) gets to implement it. Please file an issue in https://github.com/dontcallmedom/github-notify-ml/ for that feature. |
it may be that this matches dontcallmedom/github-notify-ml#49 already |
Yes, that looks like what we'd want! But I think for now we can work around the issue by not relying on a label change alone, so no rush to implement it. It'll probably be the case that most final review requests come out of our meetings and there will be an automatic comment added that the issue was discussed. For any others we just want to close off after a review period, we can comment that that's what we're doing when we slap the label on to make sure the activity gets picked up for the log. I think we're good to merge this now. Thanks for all your help and for making this tool available! I only wish we'd known we could do this in the last revision; it's a great way to give the group a recap of all the activity that goes on. |
@dontcallmedom (or to anyone else who can answer this) We're trying to enable a weekly digest for the epub specifications that will include all new activity (issues, comments, pull requests) and also select pull requests and issues that are labeled in final review.
I've used a
sources
key with two entries for the epub-specs repository to accomplish this, but please let me know if this won't accomplish what we want or if there's a better way to do it. (I'm not sure if we merged the events into one entry if the event filter would prevent new activity not labeled as final review from being captured or if it only affects .labeled activity.)Thanks!
/cc @iherman @wareid @shiestyle