Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considered for event timing: drag & drop #52

Closed
annevk opened this issue May 24, 2019 · 2 comments · Fixed by #64
Closed

Considered for event timing: drag & drop #52

annevk opened this issue May 24, 2019 · 2 comments · Fixed by #64

Comments

@annevk
Copy link
Member

annevk commented May 24, 2019

What about drag & drop events?

@npm1
Copy link
Collaborator

npm1 commented Jun 3, 2019

Good idea, we can add those to the regular Event Timing! Just to be sure, do they also go through event dispatch logic, so no additional changes would be needed in the spec other than augmenting the list of event types?

@annevk
Copy link
Member Author

annevk commented Jun 7, 2019

The change required depends on #49, but they use Event and EventTarget if that's what you mean.

npm1 added a commit that referenced this issue Jan 9, 2020
Fixes #52. This PR augments the set of event types that are supported by Event Timing. It also removes continuous event types, since there needs to be a better way to aggregate the entries that would be created from those events (eventCounts only works well for discrete event types).
@npm1 npm1 closed this as completed in #64 Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants