Add AXCustomContent for DPUB roles. #15
Conversation
| <ul> | ||
| <li>AXRole: <code>AXLink</code></li> | ||
| <li>AXSubrole: <code><nil></code></li> | ||
| <li>AXRoleDescription: <code>'link'</code></li> |
There was a problem hiding this comment.
TBD... Should 'doc-backlink' use a new subrole and should it include "back" in the role description. Note: DPUB Spec and AAM docs would need Privacy warnings if clients remapped this, because it would potentially allow AT detection. See w3ctag/design-principles#293 for more.
There was a problem hiding this comment.
Leaving as-is. Can revisit later if needed.
There was a problem hiding this comment.
James couldn't browsers also check to see if the role is doc-backlink and apply different CSS styling to denote a backlink vs. a regular link? Not sure this would only be accessed by AT only.
I personally would like to see "backlink" in an additional
{ label: "type", value: "backlink" }'backlink'
There was a problem hiding this comment.
Is there a risk of AT detection here beyond what would exist for any link? Back links aren't only for AT users. ebook readers lack back buttons, so they're widely available to everyone in publications. It's used as a means of getting back to a footnote reference, for example.
I agree the context of getting the user back to the starting reference is helpful here, so having "back" in the description would be useful.
There was a problem hiding this comment.
Is there a risk of AT detection here beyond what would exist for any link?
Yes. Any activation that does not include a prior focus, or other pointer-related events, etc. would indicate the potential for AT detection. Some of the factors could be mitigated, but without further guidance from the TAG on w3ctag/design-principles#293 I would rather address that separately in a standalone issue.
| <li>AXRole: <code>AXGroup</code></li> | ||
| <li>AXSubrole: <code>AXLandmarkRegion</code></li> | ||
| <li>AXRoleDescription: <code>'region'</code></li> | ||
| <li>AXCustomContent:<code>{ label: "type", value: "prolog" }</code></li> |
There was a problem hiding this comment.
[sic] "prolog" could be "prologue" in the en-uk l10n
There was a problem hiding this comment.
Maybe an issue with this diff preview but it looks like this is modifying "doc-pagebreak" not "doc-preface" ??
ie.
Expose
ROLE_LANDMARKand object attributexml-roles:doc-pagebreak.
+ <td>AXRole: <code>AXGroup</code><br /> AXSubrole: <code>AXLandmarkRegion</code><br />
+ <td>
+ <ul>
+ <li>AXRole: <code>AXGroup</code></li>
+ <li>AXSubrole: <code>AXLandmarkRegion</code></li>
+ <li>AXRoleDescription: <code>'region'</code></li>
+ <li>AXCustomContent:<code>{ label: "type", value: "preface" }</code></li>
+ </ul>
There was a problem hiding this comment.
I don't understand. You're commenting on the section covering prologue (not pagebreak or preface).
There was a problem hiding this comment.
Found it in a different section. For future reference, you can click on the line number to add a new comment rather than overloading an unrelated conversation.
There was a problem hiding this comment.
You can also click the button in the left of the blue collapse row (labeled "Expand All") to see additional diffs. That shows that I am editing the correct "preface" section, but the previous API seems so erroneously include "pagebreak". Will you file a new issue @clapierre? Good catch.
| <ul> | ||
| <li>AXRole: <code>AXLink</code></li> | ||
| <li>AXSubrole: <code><nil></code></li> | ||
| <li>AXRoleDescription: <code>'link'</code></li> |
There was a problem hiding this comment.
Leaving as-is. Can revisit later if needed.
| @@ -1026,8 +1208,13 @@ <h3>Role Mapping Table</h3> | |||
| </td> | |||
| <td><p>Expose <code>ROLE_LANDMARK</code> and object attribute | |||
| <code>xml-roles:doc-pagebreak</code>. </p></td> | |||
There was a problem hiding this comment.
In a comment below, I think @clapierre was referring to this errata.... (pagebreak not preface in a different API, not the AX API changes I am modifying). I would recommend filing a new issue for this since it's unrelated to my change.
There was a problem hiding this comment.
@clapierre can you verify if this is the issue you had and open a new issue to correct if so?
Otherwise, please give the updated PR a review and approve it if you're good with the changes now.
There was a problem hiding this comment.
Yes I filed #16 as a separate issue for the page break/preface issue, this PR looks good and I will approve it :)
There was a problem hiding this comment.
Ah, I didn't even see that! Thanks, I'll merge this now so we can move on with that issue.
|
Yes, many thanks @cookiecrook for all your help getting this done! |
|
Just to be clear, these type strings are localized strings, correct? |
That's my understanding, yes, going by some of @cookiecrook's earlier comments such as this one: #15 (comment) |
|
@cookiecrook sorry for the late comment — do you want to make that clear, or would you think it's obvious because of developer docs for AXCustomContent? |
|
@aleventhal @mattgarrish That should be a new issue, perhaps to match the ARIA spec section on localizable/translatable attributes? |
Closes w3c/aria#1643
Preview | Diff