Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-transform] Define "containing block for all descendants" #2185

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

trchen1033
Copy link
Contributor

Add a new definition "containing block for all descendants" and specify
that values other than 'none' on 'transform', 'transform-style',
'perspective' will cause an element to establish a containg block for
all descendants.

@dirkschulze
Copy link
Contributor

Proposal to address #913

@chrishtr
Copy link
Contributor

Tab can you review/merge this?

css-transforms-1/Overview.bs Outdated Show resolved Hide resolved
@@ -62,7 +62,7 @@ Module Interactions {#module-interactions}

The <a>3D transform functions</a> here extend the set of functions for the 'transform' property.

Some values of 'perspective', 'transform-style' and 'backface-visibility' result in the creation of a <a href="https://www.w3.org/TR/CSS2/visuren.html#containing-block">containing block</a>, and/or the creation of a <a spec="css2">stacking context</a>.
Some values of 'perspective', 'transform-style' and 'backface-visibility' result in the creation of a [=containing block for all descendants=], and/or the creation of a <a spec="css21">stacking context</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document doesnt' appear to define the term anywhere. (Unless it was already defined in some section that doesn't show up in this diff? Bikeshed doesn't seem to know the term, tho.) You can't rely on preceding versions of the document for a definition, it needs to be duplicated into here as well.

Copy link
Contributor Author

@trchen1033 trchen1033 Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I could explicitly export a general definition by <dfn export>. Do you mean that auto-link won't simply cross-reference them? Shall I change it to a <a href> instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the definition lives in a previous version of the same shortname. Bikeshed has automatic logic to ignore previous versions of a spec, because that's nearly always what you want to do. In particular, if a later version omits a definition that the previous version had, this was probably for a good reason! You thus don't want autolinking to continue to point to the old version; you want it to fail so you can notice the breakage and update things.

You want to make sure that the latest version of a given spec has all the definitions that you expect to need; in this case that means adding a <dfn> somewhere in this document.

@tabatkins
Copy link
Member

r+ after requested changes

Add a new definition "containing block for all descendants" and specify
that values other than 'none' on 'transform', 'transform-style',
'perspective' will cause an element to establish a containg block for
all descendants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-transforms-1 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants