Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Pending pull requests #5314

Open
svgeesus opened this issue Jul 13, 2020 · 4 comments
Open

[meta] Pending pull requests #5314

svgeesus opened this issue Jul 13, 2020 · 4 comments
Labels

Comments

@svgeesus
Copy link
Contributor

CSSWG Editors, please remember to check open pull requests and either approve them, request changes, or refuse them (ideally with a reason).

Ageing pull requests accumulate conflicts with the head, and are harder to merge after a lengthy delay.

If a PR has poor changes, close it.

If a PR suggests changes that expose some flaw in the spec, but you want discussion first, open an issue and then close the PR.

@frivoal
Copy link
Collaborator

frivoal commented Jul 14, 2020

I've closed/merge a few, but many remain. To help triage the rest, I've made sure all open PRs are labeled with the right spec.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [meta] Pending pull requests.

The full IRC log of that discussion <dael> Topic: [meta] Pending pull requests
<dael> github: https://github.com//issues/5314
<dael> chris: Reminder, lots of PRs that are old. As long as they languish the older they get
<dael> chris: You can reject if you don't like, but please keep on top of it
<dael> chris: Quick reminder
<dael> plinss: We have 5 additional brances in main repo with 5 PRs. 4 have PRs open with 1-3 years old. Please review and handle. Then please don't branch from main.
<dael> florian: Can we kill the one without a PR?
<dael> plinss: It's from TabAtkins
<dael> TabAtkins: Okay, will take care of it

@dbaron
Copy link
Member

dbaron commented Jul 15, 2020

There are also open pull requests in fxtf-drafts and in css-houdini-drafts.

@svgeesus svgeesus removed the Agenda+ label Jul 20, 2020
@SebastianZ
Copy link
Contributor

Quick reminder, we still have a lot of open PRs. We should try to merge or close them.

Sebastian

@SebastianZ SebastianZ added the meta label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants