Skip to content

Update: clarify / expand value attribute mappings #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2025
Merged

Update: clarify / expand value attribute mappings #2373

merged 6 commits into from
Sep 3, 2025

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Nov 8, 2024 •
edited by pr-preview bot
Loading

replacement for w3c/html-aam#396

closes w3c/html-aam#314

This should largely be reflecting what is currently happening in browsers.

Preview | Diff

@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 815ca24
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/68b83b3026dc79000887228a
😎 Deploy Preview https://deploy-preview-2373--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@scottaohara scottaohara mentioned this pull request Nov 8, 2024
Closed
@pkra pkra mentioned this pull request Nov 11, 2024
Closed
21 tasks
MelSumner
MelSumner approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@spectranaut spectranaut moved this from All PRS to Needs Review in ARIA Normative PR Tracking Jun 13, 2025
@spectranaut spectranaut requested a review from adampage June 19, 2025 17:38
cookiecrook
cookiecrook approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with change suggestions.

spectranaut
spectranaut approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change is documenting browsers, then I think it should land!

I like Jame's suggestions and have one minor point of confusion.

@spectranaut spectranaut moved this from Needs Review to Needs updates from review in ARIA Normative PR Tracking Jul 3, 2025
@spectranaut
Copy link
Contributor

We need to fix this branch before landing, something crazy is happening.

@pkra
Copy link
Member

pkra commented Jul 9, 2025

@spectranaut this looks similar to the problem in #2235. @daniel-montalvo do you have any insights?

@daniel-montalvo
Copy link
Contributor

@spectranaut this looks similar to the problem in #2235. @daniel-montalvo do you have any insights?

@pkra @spectranaut
I merged main and pushed the changes (didn't rebase though). Now this shows only one changed file html-aam/index.html and
we have a more comprehensible diff. Is this any better?

@spectranaut
Copy link
Contributor

I think this is ready to merge @scottaohara !

@spectranaut spectranaut moved this from Needs updates from review to Merge? in ARIA Normative PR Tracking Aug 26, 2025
@rahimabdi rahimabdi self-requested a review August 27, 2025 17:32
@rahimabdi rahimabdi self-assigned this Aug 27, 2025
scottaohara and others added 5 commits September 3, 2025 14:15
@daniel-montalvo
Copy link
Contributor

@spectranaut @scottaohara

I solved one conflict originated from merging j #2309 so as Val said I think this is ready to merge.

@scottaohara scottaohara merged commit 0ce7769 into main Sep 3, 2025
6 checks passed
@scottaohara scottaohara deleted the value-mappings branch September 3, 2025 16:53
@github-project-automation github-project-automation bot moved this from Merge? to Waiting For Implementation in ARIA Normative PR Tracking Sep 3, 2025
@scottaohara scottaohara restored the value-mappings branch September 3, 2025 19:09
@scottaohara
Copy link
Member Author

@daniel-montalvo @spectranaut looks like something didn't work right in publishing after merge.

@spectranaut
Copy link
Contributor

@daniel-montalvo @spectranaut looks like something didn't work right in publishing after merge.

I think because of this: #2616

Can you review/merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spectranaut spectranaut spectranaut approved these changes

@cookiecrook cookiecrook cookiecrook approved these changes

@adampage adampage adampage approved these changes

@MelSumner MelSumner MelSumner approved these changes

@rahimabdi rahimabdi Awaiting requested review from rahimabdi

Assignees

@rahimabdi rahimabdi

Labels

spec:html-aam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

value should map to aria-valuenow for input[type=range]

8 participants

@scottaohara @spectranaut @pkra @daniel-montalvo @cookiecrook @adampage @MelSumner @rahimabdi