Add heading and separator roles to feed's allowed accessibility children#2245
Add heading and separator roles to feed's allowed accessibility children#2245
Conversation
|
In The feed role , "Authors MAY use heading and separator children in a feed . For example, in a feed of news stories there could be headings separating sets of articles into sequential dates. If a feed does have headings or separators as children, they SHOULD NOT be focusable or contain information necessary for understanding or navigating the feed 's articles ." Confused with last sentence "If a feed does have headings or separators as children, they SHOULD NOT be focusable or contain information necessary for understanding or navigating the feed 's articles ". May be provide examples like timestamp and name etc. Provide some explicit info Also, will there be any related info is added to the heading and the separator role? |
|
Should we consider adding the When dealing with a high but "static" number of articles, showing them on scroll for any reason (e.g. for performance reasons), this setup might be one of the rare cases where an author would want to create a custom scrollbar. I understand that the scrollbar can be positioned outside the feed element, but I don't see why the author shouldn't be allowed to place it inside, as the scrollbar is an integral part of the feed document. Regarding the rest of the addition, I like it. The details about focusability and not including important text are crucial for maintaining a smooth experience for keyboard users. |
@giacomo-petri this makes sense to me! Though I think scrollbar should generally be an allowed child of any composite widget, not just feed. Probably as a separate PR, or as part of the roles categorization that @scottaohara mentioned on the last ARIA call -- WDYT? |
|
@shirsha the sentence you quoted contains an example in it -- "For example, in a feed of news stories there could be headings separating sets of articles into sequential dates." Is that example enough to address your comment, or is there additional information you want included? I didn't add anything to the heading and separator role sections, since this change doesn't affect their usage outside of feed. |
|
The ARIA Working Group just discussed The full IRC log of that discussion<ZoeBijl> topic: review: normative pr checklist<ZoeBijl> we refined the checklist after monorepo <ZoeBijl> https://github.com//pull/2245 <ZoeBijl> Github: https://github.com//pull/2245 |
|
@smhigley rebased on main. |
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
spectranaut
moved this from Needs Review
to Reviewed, other needs
in ARIA Normative PR Tracking
| <code>-1</code> or <code>0</code>. | ||
| </p> | ||
| <p> | ||
| Authors MAY use <rref>heading</rref> and <rref>separator</rref> children in a <code>feed</code>. For example, in a feed of news stories there could be headings separating sets of |
There was a problem hiding this comment.
| Authors MAY use <rref>heading</rref> and <rref>separator</rref> children in a <code>feed</code>. For example, in a feed of news stories there could be headings separating sets of | |
| Authors MAY use elements with role <rref>heading</rref> and <rref>separator</rref> as <a>accessibility children</a> of an element with role <code>feed</code>. For example, in a feed of news stories there could be headings separating sets of |
| <p> | ||
| Authors MAY use <rref>heading</rref> and <rref>separator</rref> children in a <code>feed</code>. For example, in a feed of news stories there could be headings separating sets of | ||
| articles into sequential dates. If a <code>feed</code> does have <rref>headings</rref> or <rref>separators</rref> as children, they SHOULD NOT be focusable or contain information | ||
| necessary for understanding or navigating the <code>feed</code>'s <rref data-lt="article">articles</rref>. |
There was a problem hiding this comment.
I'm not sure about the two SHOULD NOTs.
For the first part is about focusability. Why should headings not be focusable? I'm not sure if the APG example is any good, but thinking about this change from that example, it seems to me a user may want to stop at headings when navigating through the feed.
The second part is about the contents. I feel that's out of scope for ARIA - it feels WCAG-ish to me. Without much deep diving, I couldn't find anything like it in the spec. Are we sure we want to start with this?
There was a problem hiding this comment.
For comparison, #2159 uses a note for similar author guidance.
spectranaut
moved this from Reviewed, other needs
to Needs updates from review
in ARIA Normative PR Tracking
|
🚀 Deployed on https://deploy-preview-2245--wai-aria.netlify.app |
7 participants
🚀 Netlify Preview:
🔄 this PR updates the following sspecs:
Closes #2236
Based on the working group discussion of the linked issue, we decided to make a quick PR to add heading & separator to feed, and work on ARIA role content models separately. At some point, the content model approach may replace the heading/separator addition when it's ready.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff