[html-aam PR 451] clarify img mappings #2221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #439 This PR provides more detailed conditions for when an `img` element is mapped to the `img` role. This was originally brought up to address what should happen when an `img` lacks or has been given an `src` attribute set to the empty string, as HTML defines such instances as "representing nothing". However, in trying to just add in that condition, it made me realize the mappings were lacking additional nuance to how the element is exposed re: the existence of alternative naming mechanisms besides just `alt`.
21 tasks
pkra
changed the title
|
Now pointing to main. |
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Re-assigning reviewers @cookiecrook @smhigley @jnurthen. |
scottaohara
reviewed
Aug 12, 2024
scottaohara
reviewed
Aug 12, 2024
scottaohara
reviewed
Aug 12, 2024
6 tasks
|
need to come back to this as whatwg/html#11300 was merged into HTML |
smhigley
approved these changes
Jun 26, 2025
cookiecrook
requested changes
Jul 3, 2025
| or <a class="core-mapping" href="#role-map-img">`img`</a> role | ||
| <div> | ||
| If element has a non-empty `src` or `srcset` attribute, an <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a>, or both, then map to the | ||
| <a class="core-mapping" href="#role-map-image">`img`</a> or <a class="core-mapping" href="#role-map-img">`image`</a> role. |
There was a problem hiding this comment.
Are these typos? Link text for #…image is "img", and vice versa link text for #…img is "image"…
Regardless, these should both map to the primary synonym: "image"
Suggested change
| <a class="core-mapping" href="#role-map-image">`img`</a> or <a class="core-mapping" href="#role-map-img">`image`</a> role. | |
| <a class="core-mapping" href="#role-map-image">`image`</a> role. |
| </div> | ||
| <div> | ||
| Otherwise, if the element has no `src` or `srcset` attribute, or if the attribute(s) are set to the empty string, and the `img` has no `alt` attribute or accessible name, then map to | ||
| the <a class="core-mapping" href="#role-map-none">`none`</a> or <a class="core-mapping" href="#role-map-presentation">`presentation`</a> role. |
There was a problem hiding this comment.
none, not presentation.
Suggested change
| the <a class="core-mapping" href="#role-map-none">`none`</a> or <a class="core-mapping" href="#role-map-presentation">`presentation`</a> role. | |
| the <a class="core-mapping" href="#role-map-none">`none`</a> or <a class="core-mapping" href="#role-map-none">`none`</a> role. |
| <th>Comments</th> | ||
| <td> | ||
| <p> | ||
| An `img` with a non-empty `src`, `srcset`, or both and no `alt` attribute or <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a> will still map to the `image` role, |
There was a problem hiding this comment.
editorial
Suggested change
| An `img` with a non-empty `src`, `srcset`, or both and no `alt` attribute or <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a> will still map to the `image` role, | |
| An `img` with a non-empty `src`, `srcset`, or both and no `alt` attribute or <a data-cite="accname-1.2/#dfn-accessible-name">accessible name</a> will map to the `image` role, |
Comment on lines
13684
to
13689
| <p> | ||
| The <sref>aria-expanded</sref> attribute is applied to a focusable, interactive element that toggles visibility of content of a different element. If the element with | ||
| <sref>aria-expanded</sref> is also a <rref>treeitem</rref> in a <rref>tree</rref> or a <rref>row</rref> in a <rref>treegrid</rref>, then it SHOULD also be the | ||
| <a>accessibility parent</a> of the content it expands and collapses. Otherwise, the element with <sref>aria-expanded</sref> SHOULD NOT be the <a>accessibility parent</a> of the content | ||
| that is expanding or collapsing. Rather, identify that relationship between the interactive element and the element being controlled using <pref>aria-controls</pref>. | ||
| </p> |
There was a problem hiding this comment.
Can't use passive voice in an RFC-2119. Are these author requirements or user agent requirements? Most in HTML-AAM are UA reqs, but this looks like an author req, so:
- It should start with: "Authors SHOULD" or "Authors SHOULD NOT" in order to disambiguate.
- It should be moved to from HTML-AAM to ARIA. Isn't this authoring rule more broadly applicable than HTML? Hooray for the monorepo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from w3c/html-aam#451
Preview | Diff