Align ARIAMixin with changes in HTML #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not address most of the issues described in w3c#1110, but does provide a better base for ElementInternals support and tackling the issues in w3c#1110. Corresponding HTML change: whatwg/html#8496.
This was referenced Feb 20, 2023
|
Converting to draft until upstream PR is resolved. |
domenic
approved these changes
Feb 22, 2023
|
I think it might have to get more complicated as we address the remaining issues around |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 22, 2023
Other changes: * Remove reflection of unrestricted double as it is buggy and unused. * The DOMString getter steps did not account for a missing attribute. * The native accessibility semantics map was renamed to the internal content attribute map as it's now a more general reflection concept. Corresponding ARIA PR: w3c/aria#1876. Fixes #8442. Follow-up: * w3c/core-aam#152 * w3c/aria#1110 * #3238 * #8544 * #8545 * #8926 * #8927 * #8928 * #8930
|
Can anyone work on merging this? I got very confused implementing the current spec in jsdom. |
keithamus
reviewed
Jan 11, 2024
keithamus
approved these changes
Jan 11, 2024
cookiecrook
approved these changes
Jan 11, 2024
spectranaut
reviewed
Feb 15, 2024
|
This looks ready to merge per today's meeting (https://www.w3.org/2024/02/15-aria-minutes#t08) - I'll resolve merge conflicts and land. |
github-actions bot
added a commit
that referenced
this pull request
Feb 15, 2024
SHA: d2c9883 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not address most of the issues described in #1110, but does provide a better base for ElementInternals support and tackling the issues in #1110.
Corresponding HTML change: whatwg/html#8496.
This is meant to be editorial when combined with the HTML PR landing around the same time, leaving existing spec-UB as spec-UB. Please do not merge this before the HTML PR is merged.
cc @domenic
Preview | Diff