Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue template fix - remove extra 'at' #1825

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Conversation

scottaohara
Copy link
Member

removes an extra "at." from the end of the second heading.

Other bits to consider before this otherwise quick typo PR is merged:

  1. "Link to documentation:" rendering as a paragraph - not sure if that's also meant to be a heading or if it's representative of placeholder content?
  2. The headings are being rendered as <h1>s since they're using the single # markdown for headings. Is that what we want here? Maybe a bit persnickety to bring this up, but also does go against the general a11y best practice for using level 1 headings. This would apply to all the recent issue/pr templates.

removes an extra "at." from the second heading
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol thanks!

@spectranaut spectranaut merged commit 78af4a5 into main Oct 8, 2022
github-actions bot added a commit that referenced this pull request Oct 8, 2022
SHA: 78af4a5
Reason: push, by @spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants