Skip to content

Clarify invocation parameters for callback #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Clarify invocation parameters for callback #455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b5de91
Clarify invocation parameters for callback.
szager-chromium Sep 23, 2020
e7f24e3
Fix "callback this value" language.
szager-chromium Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ urlPrefix: https://html.spec.whatwg.org/multipage/
url: #event-loop-processing-model; type: dfn; text: HTML Processing Model
url: #concept-environment-top-level-origin; type: dfn; text: top-level origin
urlPrefix: infrastructure.html;
type: dfn; text: rules for parsing dimension values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the reference to rules for parsing dimension values is probably not intended?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That reference is no longer used in the spec, this is just cleanup that snuck into this patch. I can remove it if you'd prefer a clean patch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine. Maybe note it in the commit message?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

url: #dfn-callback-this-value; type: dfn; text: callback this value
urlPrefix: origin.html
type: dfn; text: origin
Expand Down Expand Up @@ -568,8 +567,8 @@ run these steps:
2. Let |queue| be a copy of |observer|'s internal {{[[QueuedEntries]]}}
slot.
3. Clear |observer|'s internal {{[[QueuedEntries]]}} slot.
4. Invoke |callback| with |queue| as the first argument and |observer|
as the second argument and <a>callback this value</a>.
4. Invoke |callback| with |queue| as the first argument, |observer| as the second argument,
and |observer| as the <a>callback this value</a>.
If this throws an exception, <a>report the exception</a>.

<h4 id='queue-intersection-observer-entry-algo'>
Expand Down