Skip to content

Refactor code #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Refactor code #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1dd42ec
Refactor code
w3bdesign Jan 30, 2023
62bec24
Refactor code
w3bdesign Jan 30, 2023
cc4ec4f
Improve commonbutton description
w3bdesign Jan 30, 2023
a04e3db
Revert "Improve commonbutton description"
w3bdesign Jan 30, 2023
577d738
Improve commonbutton description
w3bdesign Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions components/Checkout/CheckoutButton.vue
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion components/Checkout/CheckoutForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</ErrorMessage>
</div>
<div class="w-full flex justify-center mt-6">
<CheckoutButton />
<CommonButton>SUBMIT ORDER</CommonButton>
</div>
</div>
</Form>
Expand Down
0 components/Cart/CartAddToCartButton.vue → ...ents/Products/ProductsAddToCartButton.vue
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion components/Products/ProductsSingleProduct.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
</select>
</p>
<div class="pt-1 mt-2">
<CartAddToCartButton :product="data.product" />
<ProductsAddToCartButton :product="data.product" />
</div>
</div>
</div>
Expand Down
4 changes: 3 additions & 1 deletion components/common/CommonButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<button
:class="{ disabled: isLoading }"
@click="$emit('CommonButtonClick')"
type="submit"
>
<slot />
<svg
Expand All @@ -29,6 +30,7 @@
<button
:class="{ disabled: isLoading }"
@click="$emit('CommonButtonClick')"
type="submit"
>
<slot />
<svg
Expand All @@ -54,7 +56,7 @@
<script setup>
/*
* Usage:
* <CommonButton @common-button-click="functionName" isLoading="true">Common button</CommonButton>
* <CommonButton @common-button-click="functionName" is-loading="true" link-to="/link">Common button</CommonButton>
*/

defineEmits(["CommonButtonClick"]);
Expand Down