Binding Parameters Bug Fix and Version Bump #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*[binding-params] Accept optional params array as an argument to the query method *[binding-params] Bypass binding parameters and use SQLExecDirect if there is no params array The original pull request for binding params seems to have missed some critical parts. This commit fixes these shortcomings. The issues were: * odbc.js's query method was modified to accept a `params` array, but this array was not passed on to the cpp side of things * Database.ccp was modified to populate prep_req->params if arg[1] was an array, but it was never an array because it wasn't passed from javascript land. * SQLPrepare and SQLExecute were always used even when there was no need to if no parameter array was passed.
w1nk
added a commit
that referenced
this pull request
Jan 24, 2012
Binding Parameters Bug Fix and Version Bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix binding-params queries and only use them when needed
The original pull request for binding params seems to have missed some critical parts. This
commit fixes these shortcomings. The issues were:
paramsarray, but this array was not passed on to the cpp side of thingsI have also bumped the version to v0.3.1 which should be inline for the next npm release.