Repository navigation
build(deps): bump protobuf from 4.25.9 to 5.29.6 in /tools/training - #22
Merged
Merged
Conversation
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 4.25.9 to 5.29.6. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: protobuf dependency-version: 5.29.6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
w0rldx
requested changes
Aug 22, 2026
w0rldx
left a comment
w0rldx
left a comment
Owner
There was a problem hiding this comment.
Dependency resolution and CI are green, but this is not merge-ready yet.
- Please raise the manifest floor to
protobuf>=5.29.6,<6.0.0; the current>=4.21.0declaration still permits the vulnerable range even though this lock closes the alert. Regenerate withuv lock --upgrade-package 'protobuf==5.29.6'.\n2. This crosses protobuf 4 -> 5, while the required jobs do not provision the shipped multi-GB training runtime. Before approval, run the repository-required isolated training-runtime/GPU/conversion validation: import/version matrix, representative protobuf JSON/Any/model-config roundtrip, minimal CUDA training checkpoint, and the real GGUF conversion/load path.\n\nKeep this as a separate PR and merge it before rebasing the Transformers 5 lane.
Review item 1 on #22: the bump moved only the ceiling, so the manifest still declared protobuf>=4.21.0 and kept admitting the versions the advisory covers even though this lock pins 5.29.6. Declare the floor the review asked for, >=5.29.6,<6.0.0, so the constraint states the security requirement instead of relying on the lock to hold it. Re-locked: the resolved closure is unchanged at 102 packages, no package version moves, and only the recorded requirement string in uv.lock changes. uv lock --check is clean.
Owner
|
Applied review item 1 in |
w0rldx
approved these changes
Aug 23, 2026
dependabot
Bot
deleted the
dependabot/uv/tools/training/protobuf-5.29.6
branch
August 23, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps protobuf from 4.25.9 to 5.29.6.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.