Add PHP 8.4 to CI and fix test method naming to follow camelCase convention #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes. First, it adds PHP 8.4 to the test matrix, as the version has been officially released for over five months and is currently in its active support phase. Ensuring compatibility with PHP 8.4 is important for forward-compatibility and maintaining the reliability of the package across supported environments.
The second change corrects the naming style of PHPUnit test methods. While reviewing the updates made in PR #616, "Fixed php-8.4 deprecations" by @sergonie, I realized that my earlier PR #622, "Fix formatting and clean up deprecated docker-compose v1 from CI", unintentionally changed test method names from camelCase to snake_case.
The Pint configuration added in PR #616 explicitly defined the use of camelCase, which reflects the historical naming convention used in this package. This PR restores that convention by renaming all test methods back to camelCase for consistency.