Add $dispatchAfterCommit when running via custom worker #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-worker Add $dispatchAfterCommit when running via custom worker
|
@vyuldashev Hey, could you allow the workflow to run so we can at least see if its green (✅ )? Thanks! |
jeromegamez
added a commit
to jeromegamez/vyuldashev-laravel-queue-rabbitmq
that referenced
this pull request
Jan 3, 2023
|
Hi @wietsewarendorff, thanks for your submission. Unfortunately, we can't accept it as-is, since it would break any existing workers as soon as it's merged. We're evaluating other options (most likely a Service Provider) for use in the next major version. |
|
Duplicate of #513 , closing this one and moving the convo over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.